(CONT-347) - correct centos/alma/rocky 8 hanging tests #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
requested review from
a team,
alexjfisher,
bastelfreak,
deric,
ekohl,
SimonHoenscheid and
smortex
as code owners
jordanbreen28
force-pushed
the
CONT-347-address_cancelled_ci_runs
branch
21 times, most recently
from
6a3d884 to
2ecf852
Compare
jordanbreen28
force-pushed
the
CONT-347-address_cancelled_ci_runs
branch
11 times, most recently
from
5f18535 to
ee5bf23
Compare
jordanbreen28
force-pushed
the
CONT-347-address_cancelled_ci_runs
branch
6 times, most recently
from
3486054 to
72e79a1
Compare
jordanbreen28
changed the title
jordanbreen28
force-pushed
the
CONT-347-address_cancelled_ci_runs
branch
from
72e79a1 to
edd4a5e
Compare
jordanbreen28
force-pushed
the
CONT-347-address_cancelled_ci_runs
branch
2 times, most recently
from
38b85d1 to
cd3f3f4
Compare
jordanbreen28
force-pushed
the
CONT-347-address_cancelled_ci_runs
branch
from
cd3f3f4 to
2e294c7
Compare
chelnak
approved these changes
Jun 19, 2023
SimonHoenscheid
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the hanging tests found on el8 based litmus images like centos 8, alma 8 and rocky 8.
This issue was caused by Postgres smart shutdown functionality that would not shut down PGSQL if there was an active client connection.
This PR utilises
pg_ctlto allow rspec to terminate those connections before executing the next set of tests.