Skip to content

(CONT-950) - Fix mismatched data types #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2023
Merged

(CONT-950) - Fix mismatched data types #1430

merged 4 commits into from
May 2, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented May 2, 2023 •
edited
Loading

Fixes #1426
Fixes #1423

jordanbreen28 added 2 commits May 2, 2023 14:23
(CONT-950) - Resolve inadequate datatype for $value
c7b7206 
Resolves an issue introduced during the syntax update carried out in
this module.
The parameter $value in config_entry, can be either a String, Integer or Float.
However, it was wrongly set to exclude Floating point numbers.
(CONT-950) - Array of $listen_addresses
339ea33 
This commit adds functionality to allow an array of $listen_addresses to
be specified as a string containing a comma-seperated list of addresses,
which was removed unintentioanlly in #1397.

Fixes #1426.
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner May 2, 2023 14:29
@jordanbreen28 jordanbreen28 self-assigned this May 2, 2023
@puppet-community-rangefinder
Copy link

postgresql::server is a class

Breaking changes to this file WILL impact these 42 modules (exact match):
Breaking changes to this file MAY impact these 17 modules (near match):

postgresql::server::config_entry is a type

Breaking changes to this file WILL impact these 6 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

postgresql::server::instance::config is a type

that may have no external impact to Forge modules.

This module is declared in 70 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

ekohl
ekohl reviewed May 2, 2023
View reviewed changes
LukasAud
LukasAud approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 87fab00 into main May 2, 2023
@LukasAud LukasAud deleted the CONT-950-fix_mismatched_data_types branch May 2, 2023 15:41
ekohl
ekohl reviewed May 8, 2023
View reviewed changes
manifests/server/config_entry.pp
@@ -6,7 +6,7 @@
#
define postgresql::server::config_entry (
Enum['present', 'absent'] $ensure = 'present',
Optional[Variant[String[1], Integer]] $value = undef,
Optional[Variant[String[1], Numeric]] $value = undef,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1426 (comment) suggests this should have accepted an array as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh!
Opened #1434 to resolve.
Thanks @ekohl

@ekohl ekohl mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@LukasAud LukasAud LukasAud approved these changes

Assignees

@jordanbreen28 jordanbreen28

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[9.0.1] breaks listen_addresses and increase the chance off an miss configuration Wrong data type for postgresql::server::config_entry::value
3 participants
@jordanbreen28 @ekohl @LukasAud