Skip to content

Fix wrong data type for data_checksums parameter #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions REFERENCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ Default value: `undef`

##### <a name="-postgresql--globals--data_checksums"></a>`data_checksums`

Data type: `Optional[String[1]]`
Data type: `Optional[Boolean]`

Use checksums on data pages to help detect corruption by the I/O system that would otherwise be silent.
Warning: This option is used during initialization by initdb, and cannot be changed later.
Expand Down Expand Up @@ -1204,9 +1204,9 @@ Default value: `$postgresql::params::locale`

##### <a name="-postgresql--server--data_checksums"></a>`data_checksums`

Data type: `Optional[String[1]]`
Data type: `Optional[Boolean]`

Boolean. Use checksums on data pages to help detect corruption by the I/O system that would otherwise be silent.
Use checksums on data pages to help detect corruption by the I/O system that would otherwise be silent.
Warning: This option is used during initialization by initdb, and cannot be changed later. If set, checksums are calculated for all objects, in all databases.

Default value: `$postgresql::params::data_checksums`
Expand Down
2 changes: 1 addition & 1 deletion manifests/globals.pp
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@

Optional[String[1]] $encoding = undef,
Optional[String[1]] $locale = undef,
Optional[String[1]] $data_checksums = undef,
Optional[Boolean] $data_checksums = undef,
Optional[String[1]] $timezone = undef,

Optional[Boolean] $manage_pg_hba_conf = undef,
Expand Down
4 changes: 2 additions & 2 deletions manifests/server.pp
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
#
# @param encoding Sets the default encoding for all databases created with this module. On certain operating systems this is also used during the template1 initialization, so it becomes a default outside of the module as well.
# @param locale Sets the default database locale for all databases created with this module. On certain operating systems this is used during the template1 initialization as well, so it becomes a default outside of the module.
# @param data_checksums Boolean. Use checksums on data pages to help detect corruption by the I/O system that would otherwise be silent.
# @param data_checksums Use checksums on data pages to help detect corruption by the I/O system that would otherwise be silent.
# Warning: This option is used during initialization by initdb, and cannot be changed later. If set, checksums are calculated for all objects, in all databases.
#
# @param timezone Set timezone for the PostgreSQL instance
Expand Down Expand Up @@ -138,7 +138,7 @@

Optional[String[1]] $encoding = $postgresql::params::encoding,
Optional[String[1]] $locale = $postgresql::params::locale,
Optional[String[1]] $data_checksums = $postgresql::params::data_checksums,
Optional[Boolean] $data_checksums = $postgresql::params::data_checksums,
Optional[String[1]] $timezone = $postgresql::params::timezone,

Boolean $manage_pg_hba_conf = $postgresql::params::manage_pg_hba_conf,
Expand Down