Skip to content

deprecate old code managing sysconfig files #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2023
Merged

deprecate old code managing sysconfig files #1400

merged 1 commit into from
Feb 15, 2023

Conversation

SimonHoenscheid
Copy link
Collaborator

  • used on RHEL6
  • old Debian and Ubuntu Versions
  • Systemd takes care of that now

@SimonHoenscheid SimonHoenscheid requested a review from a team as a code owner February 14, 2023 15:23
@puppet-community-rangefinder
Copy link

postgresql::server::config_entry is a type

Breaking changes to this file WILL impact these 6 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

postgresql::server::instance::config is a type

that may have no external impact to Forge modules.

This module is declared in 70 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

ekohl
ekohl previously approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we dropped RHEL 6 support in 32b770f (and other EL6 in other commits). If you can confirm the Debian part is no longer relevant then 👍

manifests/server/config_entry.pp
# we stop the service completely. On RHEL 7 we either have to create
# a systemd override for the port or update the sysconfig file, but this
# is managed for us in postgresql::server::config.
if $facts['os']['name'] == 'Debian' or $facts['os']['name'] == 'Ubuntu' {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer relevant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure this is no longer needed. And the systemd drop-in is not managed on debian based systems. I would rely on the tests here, but I can also test a bit on a debian based system

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do wonder how often the data directory is changed. As I mentioned elsewhere, I'm not sure it's supported to have the data directory in postgresql.conf at all. So I think it may be ok to drop. Just a bit unsure about it.

Copy link
Collaborator Author

@SimonHoenscheid SimonHoenscheid Feb 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this on many debian and ubuntu systems, changing the data directory in postgresql.conf works

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because they store it in /etc rather than /var like Red Hat does (which is crazy).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just verified this on debian 10 with postgresql 11 (debians own package, default), changing port and data directory via postgresql.conf works fine.

bastelfreak
bastelfreak previously approved these changes Feb 15, 2023
View reviewed changes
@SimonHoenscheid
deprecate old code managing sysconfig files
a24df18 
* used on RHEL6
* old Debian and Ubuntu Versions
* Systemd takes care of that now
@SimonHoenscheid SimonHoenscheid dismissed stale reviews from bastelfreak and ekohl via a24df18 February 15, 2023 09:47
@SimonHoenscheid SimonHoenscheid force-pushed the shoenscheid_remove_rhel6_old_debian_ubuntu_sysconfig_code branch from 75bf399 to a24df18 Compare February 15, 2023 09:47
@chelnak chelnak merged commit 54602cd into puppetlabs:main Feb 15, 2023
@SimonHoenscheid SimonHoenscheid deleted the shoenscheid_remove_rhel6_old_debian_ubuntu_sysconfig_code branch February 15, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@chelnak chelnak chelnak approved these changes

@bastelfreak bastelfreak bastelfreak left review comments

Assignees
No one assigned
Labels
community maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SimonHoenscheid @ekohl @bastelfreak @chelnak @ia-content @jordanbreen28