Add multi instance support, refactoring password.pp (5/x) #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postgresql::server::instance_passwd is a typethat may have no external impact to Forge modules. postgresql::server::instance_service is a typethat may have no external impact to Forge modules. postgresql::server::passwd is a classthat may have no external impact to Forge modules. postgresql::server::service is a classthat may have no external impact to Forge modules. This module is declared in 70 of 580 indexed public
|
SimonHoenscheid
force-pushed
the
shoenscheid_postgresql_instances_passwd_class_to_define
branch
from
80c79bb to
301f8b5
Compare
This commit adds changes a class to add multi instance support to this module. The general idea is to first copy all classes which are used and create defines from them. These classes will use the defines as is. Necessary changes for the instances itself will be added to the classes and defined types at a later point. This ensures, the module will work as it does right now and there are no breaking changes.
SimonHoenscheid
force-pushed
the
shoenscheid_postgresql_instances_passwd_class_to_define
branch
from
301f8b5 to
ae9d85a
Compare
bastelfreak
reviewed
Jan 30, 2023
| $port = $postgresql::server::port, | ||
| $database = $postgresql::server::default_database, | ||
| $module_workdir = $postgresql::server::module_workdir, | ||
| $postgres_password = $postgresql::server::postgres_password, |
There was a problem hiding this comment.
the indend looks a bit odd here?
chelnak
approved these changes
Jan 30, 2023
SimonHoenscheid
deleted the
shoenscheid_postgresql_instances_passwd_class_to_define
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds changes a class to add multi instance support to this module. The general idea is to first copy all classes which are used and create defines from them. These classes will use the defines as is. Necessary changes for the instances itself will be added to the classes and defined types at a later point. This ensures, the module will work as it does right now and there are no breaking changes.