Skip to content

Add multi instance support, refactoring service.pp (4/x) #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SimonHoenscheid
Copy link
Collaborator

This commit adds changes a class to add multi instance support to this module. The general idea is to first copy all classes which are used and create defines from them. These classes will use the defines as is. Necessary changes for the instances itself will be added to the classes and defined types at a later point. This ensures, the module will work as it does right now and there are no breaking changes.

@SimonHoenscheid SimonHoenscheid requested a review from a team as a code owner January 27, 2023 14:05
@puppet-community-rangefinder
Copy link

postgresql::server::instance_service is a type

that may have no external impact to Forge modules.

postgresql::server::service is a class

that may have no external impact to Forge modules.

This module is declared in 70 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@SimonHoenscheid SimonHoenscheid force-pushed the shoenscheid_postgresql_instances_service_class_to_define branch from 4c5a916 to ffa1d59 Compare January 27, 2023 14:37
This commit adds changes a class to add multi instance support to this
module. The general idea is to first copy all classes which are used and
create defines from them. These classes will use the defines as is.
Necessary changes for the instances itself will be added to the classes
and defined types at a later point. This ensures, the module will work
as it does right now and there are no breaking changes.
@SimonHoenscheid SimonHoenscheid force-pushed the shoenscheid_postgresql_instances_service_class_to_define branch from ffa1d59 to 4c0261c Compare January 30, 2023 09:57
@chelnak chelnak merged commit 17aca43 into puppetlabs:main Jan 30, 2023
@SimonHoenscheid SimonHoenscheid deleted the shoenscheid_postgresql_instances_service_class_to_define branch January 30, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants