Add multi instance support, refactoring config.pp (1/x) #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add a spec test for the defined ressource and copy parameter docs from the server class to the defined ressource if available. |
SimonHoenscheid
force-pushed
the
shoenscheid_postgresql_instances_config_class_to_define
branch
4 times, most recently
from
4c78dec to
93a08db
Compare
|
Typo in PR and commit title, "instance". |
SimonHoenscheid
changed the title
SimonHoenscheid
force-pushed
the
shoenscheid_postgresql_instances_config_class_to_define
branch
8 times, most recently
from
74c0f3f to
b2fe787
Compare
SimonHoenscheid
changed the title
This commit is the first of many to add multi instance support to this module. The general idea is to first copy all classes which are used and create defines from them. These classes will use the defines as is. Necessary changes for the instances itself will be added to the classes and defined types at a later point. This ensures, the module will work as it does right now and there are no breaking changes.
SimonHoenscheid
force-pushed
the
shoenscheid_postgresql_instances_config_class_to_define
branch
from
b2fe787 to
8f17f52
Compare
|
There seems to be a bigger issue with the acceptance tests causing hangs. Happy to merge this. |
chelnak
approved these changes
Jan 25, 2023
SimonHoenscheid
deleted the
shoenscheid_postgresql_instances_config_class_to_define
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the first of many to add multi instance support to this module. The general idea is to first copy all classes which are used and create defines from them. These classes will use the defines as is. Necessary changes for the instances itself will be added to the classes and defined types at a later point. This ensures, the module will work as it does right now and there are no breaking changes.