-
Notifications
You must be signed in to change notification settings - Fork 614
apt::source: configure repo only for current architecture #1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Commit message says nginx, but I think you mean postgresql here. |
manifests/repo/apt_postgresql_org.pp
Outdated
location => $_baseurl, | ||
release => "${facts['os']['distro']['codename']}-pgdg", | ||
repos => 'main', | ||
architecture => $facts['os']['architecture'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum. Real world example of a similar issue, just s/PostgreSQL/Apache/: If on an amd64 system you are using PostgreSQL with a proprietary lib which is only available for i386, you would add i386 architecture to your system (dpkg --add-architecture i386), install postgresql in its i386 flavor and be happy.
Not sure Puppet can handle installing from a specific arch that being said, but this seems perfectly valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this architecture mix is ugly :( and the upstream postgres repo doesnt even have i386 anymore.
@kenyon ah right. I fixed it in our nginx module and copied the text. fixed it. |
@bastelfreak and PR title :) ( |
8116edc
to
fd67362
Compare
@kenyon apt::source is the defined resource that's changed. |
fd67362
to
e37c298
Compare
Without this setting, we tell apt to download release information for all architectures apt knows. This includes i386 on amd64 systems. postgresql doesn't publish i386 packages. because of that, it results in a warning during apt update: N: Skipping acquire of configured file 'main/binary-i386/Packages' as repository 'https://apt.postgresql.org/pub/repos/apt jammy-pgdg InRelease' doesn't support architecture 'i386' This is fixed with this change.
e37c298
to
a72b875
Compare
Without this setting, we tell apt to download release information for all architectures apt knows. This includes i386 on amd64 systems. postgresql doesn't publish i386 packages. because of that, it results in a warning during apt update:
N: Skipping acquire of configured file 'main/binary-i386/Packages' as repository 'https://apt.postgresql.org/pub/repos/apt jammy-pgdg InRelease' doesn't support architecture 'i386'
This is fixed with this change.