Release prep v8.2.1 #1362
Merged
Release prep v8.2.1 #1362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ekohl
previously requested changes
Aug 23, 2022
github-actions
bot
force-pushed
the
release-prep
branch
from
91b3876 to
789052d
Compare
|
#1363 has been included in the release. |
ekohl
approved these changes
Aug 24, 2022
ekohl
reviewed
Aug 24, 2022
| @@ -2,7 +2,17 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org). | |||
|
|
|||
| ## [v8.2.0](https://github.com/puppetlabs/puppetlabs-postgresql/tree/v8.2.0) (2022-08-22) | |||
| ## [v8.2.1](https://github.com/puppetlabs/puppetlabs-postgresql/tree/v8.2.1) (2022-08-23) | |||
There was a problem hiding this comment.
Here is something I dislike about including the date in a file: it gets out of date quickly. Today it's already 2022-08-24, which you also saw with the 8.2.0 release: the changelog is changed again.
There was a problem hiding this comment.
Yeah, I agree its not ideal. We aim to get our releases out on the day they have been prepped, but it is just not always possible. 👎
There was a problem hiding this comment.
We have the same thing in our modules. Someone from Europe creates a PR, later someone from the US reviews and the next day it's merged & released. Quite often things are messy and cleaning this up with automation is non-trivial :(
GSPatton
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated release-prep through pdk-templates from commit b2e365a.
Please verify before merging: