Skip to content

Remove unused variable in reload.pp #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Mar 8, 2022

When service_reload was introduced, it made service_name redundant.

Fixes: ef1681f

When service_reload was introduced, it made service_name redundant.

Fixes: ef1681f
@ekohl ekohl requested a review from a team as a code owner March 8, 2022 15:23
@puppet-community-rangefinder
Copy link

postgresql::server::reload is a class

that may have no external impact to Forge modules.

This module is declared in 70 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chelnak chelnak merged commit ac4781c into puppetlabs:main Mar 9, 2022
@pmcmaw pmcmaw added the bugfix label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants