Skip to content

pdksync - (IAC-1787) Remove Support for CentOS 6 #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2022
Merged

pdksync - (IAC-1787) Remove Support for CentOS 6 #1324

merged 1 commit into from
Feb 8, 2022

Conversation

david22swan
Copy link
Member

(IAC-1787) Remove Support for CentOS 6
pdk version: 2.2.0

@david22swan david22swan requested a review from a team as a code owner February 8, 2022 15:26
smortex
smortex approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe since we only stop saying the module is supporting this OS.

@ekohl
Copy link
Collaborator

ekohl commented Feb 8, 2022 •
edited
Loading

I think this is OK. I guess it is intentional that RHEL 6 stays since that's not EOL. Is that correct?

@david22swan
Copy link
Member Author

@ekohl @smortex
Due to certain issues in the background we can no longer reliably test CentOS 6, so we cannot guarantee continued support, but it will likely remain compatible as we have not made any changes to the code.
RHEL 6 has similar issues and status. Once RHEL 6 reaches EOL, we will discuss whether or not code paths supporting it need to be removed and communicate this decision and timeline either way.

@ekohl
Copy link
Collaborator

ekohl commented Feb 8, 2022

I'm very well aware of the CentOS 6 issues and I'm surprised it took you this long.

And you're completely right that my underlying question was: how much can we drop. Looking at the code it suggests RHEL 6 and SLES 11 are the last Apache 2.2 systems and cleaning that up will massively simplify the codebase.

@chelnak chelnak merged commit ec2d0a2 into main Feb 8, 2022
@chelnak chelnak deleted the pdksync_IAC-1787/main/remove_centos_6_support branch February 8, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@david22swan @ekohl @smortex @chelnak