Skip to content

MODULES-11201: add service_name for Ubuntu 18.04 and later #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

MODULES-11201: add service_name for Ubuntu 18.04 and later #1306

merged 1 commit into from
Oct 4, 2021

Conversation

moritz-makandra
Copy link
Contributor

This will set $service_status for Ubuntu hosts

@moritz-makandra moritz-makandra requested a review from a team as a code owner September 29, 2021 15:14
@puppet-community-rangefinder
Copy link

postgresql::params is a class

that may have no external impact to Forge modules.

This module is declared in 70 of 578 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ekohl
ekohl requested changes Sep 29, 2021
View reviewed changes
@moritz-makandra moritz-makandra force-pushed the 11201_service_status_ubuntu branch 2 times, most recently from b0bdc0d to 046404f Compare September 30, 2021 14:24
ekohl
ekohl reviewed Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My PR has been merged. Could you rebase this? After that I think this should be good to merge.

@moritz-makandra moritz-makandra force-pushed the 11201_service_status_ubuntu branch from 046404f to 5b5aebe Compare October 4, 2021 09:33
@moritz-makandra moritz-makandra force-pushed the 11201_service_status_ubuntu branch from 5b5aebe to 2f6ab27 Compare October 4, 2021 09:37
@moritz-makandra
Copy link
Contributor Author

My PR has been merged. Could you rebase this? After that I think this should be good to merge.

I did the rebase.

@ekohl ekohl changed the title MODULES-11201: add serivce_name for Ubuntu 18.04 and later MODULES-11201: add service_name for Ubuntu 18.04 and later Oct 4, 2021
@david22swan
Copy link
Member

@moritz-makandra This looks good to me, thanks for putting the work in and getting it up :)
And thanks @ekohl For reviewing :)

@david22swan david22swan merged commit 8e040de into puppetlabs:main Oct 4, 2021
@ekohl ekohl added the feature label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moritz-makandra @CLAassistant @david22swan @ekohl