Skip to content

pdksync - (IAC-1751) - Add Support for Rocky 8 #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

david22swan
Copy link
Member

(IAC-1751) - Add Support for Rocky 8
pdk version: 2.1.1

@david22swan david22swan requested a review from a team as a code owner September 28, 2021 09:35
smortex
smortex previously approved these changes Sep 28, 2021
@david22swan david22swan force-pushed the pdksync_IAC-1751/main/add_rocky_8_support branch from 048aa1a to 8ec63d7 Compare October 29, 2021 09:32
@bastelfreak
Copy link
Collaborator

at the moment there are no rocky facts for facter 4.2: https://github.com/voxpupuli/facterdb/tree/master/facts/4.2
maybe they should be added so the unit tests actaully work on rocky.

@ekohl
Copy link
Collaborator

ekohl commented Oct 29, 2021

This module barely uses rspec-puppet-facts so it would make little difference.

@bastelfreak
Copy link
Collaborator

ah true. but if anyone wants to submit the facts anyway I'm more than happy :D

Due to the amount of machines being run in parallel on the GHA machines transient errors are beginning to appear consistently. This is a short term fix to allow for progression of the module while a plan for a more permanent solution is made.
@adrianiurca adrianiurca merged commit d08bfc6 into main Nov 3, 2021
@adrianiurca adrianiurca deleted the pdksync_IAC-1751/main/add_rocky_8_support branch November 3, 2021 13:54
cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Feb 3, 2022
…ain/add_rocky_8_support

pdksync - (IAC-1751) - Add Support for Rocky 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants