Default privileges support schemas

[fish-face]

WIP because it is dependent on PR 1298 since schema privileges require the schema parameter to be applying to all schemas (schemas can't be nested, so it doesn't make sense to set privileges for new schemas created "within the public schema" or something).

This would also benefit from acceptance tests once I know how to make them work.

[puppet-community-rangefinder]

postgresql::server::default_privileges is a type

that may have no external impact to Forge modules.

This module is declared in 70 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[fish-face]

So the acceptance tests fail on some environments because of the postgres version being installed on them. I've pushed up something which might fix that - if not I would appreciate some guidance on how to ensure the correct version is used (and if that's not possible, to skip the test in that environment, I suppose?)

[fish-face]

Any advice on getting the tests which rely on specific versions working?

[fish-face]

I think the issue was simply that the check in the module was using versioncmp(..., '10.0') rather than versioncmp(..., '10') - can you confirm that the latter is correct?

[fish-face]

Marked as not WIP.

[fish-face]

Hi, aware you are pretty busy - if you are able to have another look at this soon that would be great.

[ekohl]

I'm away until next week.

[ekohl]

Not my area of PostgreSQL but the Puppet code looks ok so I'm merging this. Thanks!