Skip to content

Inline file contents in the catalog #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Sep 16, 2021

The file() function can read a file form a module and return the content. This happens server side and is included in the catalog. This saves a request to the fileserver at runtime. That request can fail for various reasons (it's still a network). It also means that a cached catalog is sufficient and an agent can reapply it without a Puppetserver running. These files are small enough to inline in the catalog.

The file() function can read a file form a module and return the
content. This happens server side and is included in the catalog. This
saves a request to the fileserver at runtime. That request can fail for
various reasons (it's still a network). It also means that a cached
catalog is sufficient and an agent can reapply it without a Puppetserver
running. These files are small enough to inline in the catalog.
@ekohl ekohl requested a review from a team as a code owner September 16, 2021 12:04
@puppet-community-rangefinder
Copy link

postgresql::client is a class

that may have no external impact to Forge modules.

postgresql::repo::yum_postgresql_org is a class

that may have no external impact to Forge modules.

This module is declared in 70 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan david22swan merged commit 8d31148 into puppetlabs:main Sep 20, 2021
@ekohl ekohl deleted the inline-files branch September 20, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants