Skip to content

drop code for Debian 6/7 and Ubuntu 10.04/12.04 #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Aug 12, 2021

Support for these was dropped in 3d1e1e3 and e61579f, but the code
remained.

@evgeni evgeni requested a review from a team as a code owner August 12, 2021 06:33
@evgeni evgeni changed the title drop code fore Debian 6/7 and Ubuntu 10.04/12.04 drop code for Debian 6/7 and Ubuntu 10.04/12.04 Aug 12, 2021
@puppet-community-rangefinder
Copy link

postgresql::globals is a class

Breaking changes to this file WILL impact these 19 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

postgresql::server::config_entry is a type

Breaking changes to this file WILL impact these 6 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

postgresql::server::initdb is a class

that may have no external impact to Forge modules.

This module is declared in 70 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@evgeni evgeni force-pushed the old-debian-ubuntu-drop branch from bfcf178 to cde381d Compare August 12, 2021 06:34
@CLAassistant
Copy link

CLAassistant commented Aug 12, 2021

CLA assistant check
All committers have signed the CLA.

smortex
smortex previously approved these changes Aug 12, 2021
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

@evgeni
Copy link
Contributor Author

evgeni commented Aug 12, 2021

The test failures look unrelated to this change.

@ekohl
Copy link
Collaborator

ekohl commented Aug 16, 2021

Test failures should be fixed with 09b242a. Mind rebasing.

@evgeni
Copy link
Contributor Author

evgeni commented Aug 16, 2021

rebased

@ekohl
Copy link
Collaborator

ekohl commented Aug 16, 2021

Test failures are relevant. Sadly the tests in this module are quite dated.

Support for these was dropped in 3d1e1e3 and e61579f, but the code
remained.
@evgeni evgeni force-pushed the old-debian-ubuntu-drop branch from ca4912a to 8cc1660 Compare August 16, 2021 18:11
@evgeni
Copy link
Contributor Author

evgeni commented Aug 16, 2021

Updated the tests from D6 to D10 (there is no D11 for reasons ;))

@ekohl
Copy link
Collaborator

ekohl commented Aug 16, 2021

#1288 should add D11, but there's some CI issue.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@david22swan
Copy link
Member

@evgeni @ekohl
Change's look good to me and since the test failures are a known issue gonna go ahead and merge.
Setting the change to bugfix as support for the OS's has already been removed.

@david22swan david22swan merged commit 0564ece into puppetlabs:main Aug 23, 2021
@ekohl
Copy link
Collaborator

ekohl commented Aug 23, 2021

@david22swan any idea why CentOS 8 is failing? I can only see that it's timing out but is there a log of the actual run?

cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Feb 3, 2022
drop code for Debian 6/7 and Ubuntu 10.04/12.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants