Skip to content

Set default PostgreSQL version for Fedora 33 #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Set default PostgreSQL version for Fedora 33 #1202

merged 1 commit into from
Nov 4, 2020

Conversation

blackknight36
Copy link

Fedora 33 uses Postgresql 12 by default.

@blackknight36 blackknight36 requested a review from a team as a code owner October 30, 2020 20:54
@puppet-community-rangefinder
Copy link

postgresql::globals is a class

Breaking changes to this file WILL impact these 20 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 71 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sheenaajay sheenaajay self-assigned this Nov 2, 2020
Fedora 33 uses Postgresql 12 by default.
@david22swan david22swan changed the base branch from master to main November 2, 2020 12:23
@sheenaajay
Copy link
Contributor

Thanks @blackknight36 for submitting the PR. The changes looks good. We rebased the PR to run the tests successfully.
Will be closing and reopening the PR to run the CI. Thank you

@sheenaajay sheenaajay closed this Nov 2, 2020
@sheenaajay sheenaajay reopened this Nov 2, 2020
@puppet-community-rangefinder
Copy link

postgresql::globals is a class

Breaking changes to this file WILL impact these 20 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 71 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sheenaajay sheenaajay closed this Nov 2, 2020
@sheenaajay sheenaajay reopened this Nov 2, 2020
@puppet-community-rangefinder
Copy link

postgresql::globals is a class

Breaking changes to this file WILL impact these 20 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 71 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sheenaajay
Copy link
Contributor

Unit tests are failing with the following issue rodjek/rspec-puppet#811

@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@397ac0d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1202   +/-   ##
=======================================
  Coverage        ?   65.81%           
=======================================
  Files           ?       14           
  Lines           ?      351           
  Branches        ?        0           
=======================================
  Hits            ?      231           
  Misses          ?      120           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397ac0d...8729900. Read the comment docs.

@sheenaajay sheenaajay merged commit 2da32ae into puppetlabs:main Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants