Skip to content

(IAC-889) Set FastGettext.default_text_domain in Rakefile #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

sanfrancrisko
Copy link
Contributor

The spec tests were failing due to the metadata_lint Rake task exiting with a return code of 1:

bundle exec rake check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop syntax lint metadata_lint; echo $?
Running RuboCop...
Inspecting 0 files


0 files inspected, no offenses detected
---> syntax:manifests
Current textdomain ("master_domain") was not added, use FastGettext.add_text_domain !
1

See this run on TravisCI too.

According to MODULES-6598 there is a conflict with GetFastText initialisation between puppet_semantic and puppet.

This PR implements the workaround described in MODULES-6598](https://tickets.puppetlabs.com/browse/MODULES-6598), which is to set the default_text_domain parameter in GetFastText

@sanfrancrisko sanfrancrisko requested a review from a team as a code owner June 15, 2020 17:24
@daianamezdrea daianamezdrea merged commit d8db608 into master Jun 16, 2020
@sanfrancrisko sanfrancrisko deleted the fix/IAC-889/GetFastText_init_conflict branch June 16, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants