Finish conversion of postgresql_acls_to_resources_hash function
#1163
Conversation
In puppetlabs#1129 the 3 functions from this module were ported to the modern function API and namespaced. None of the boilerplate was fixed up, tests weren't updated, documentation wasn't updated etc. This commit finishes the work for the `postgresql_acls_to_resources_hash` function. The existing function documentation made it pretty clear that this function is for internal use only. As such, I've marked it `@api private` and haven't created a non-namespaced shim (like I've being doing with the other functions in this module).
postgresql::postgresql_acls_to_resources_hash is a functionThe enclosing module is declared in 50 of 578 indexed public Puppetfiles. that may have no external impact to Forge modules. postgresql_acls_to_resources_hash is a functionThe enclosing module is declared in 50 of 578 indexed public Puppetfiles. Breaking changes to this file MAY impact these modules (near match):
The enclosing module is declared in 50 of 578 indexed public Puppetfiles. Breaking changes to this file WILL impact these modules (exact match):
Breaking changes to this file MAY impact these modules (near match):
The enclosing module is declared in 50 of 578 indexed public Puppetfiles. that may have no external impact to Forge modules. These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report. Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only. |
|
I see no evidence that the modules listed by the bot above are using the non-namespaced version of the function I've removed. (I've only checked a few. I'm not going to go through them all, as that is something the bot could do itself??) |
|
Hi @alexjfisher, thank you for your contribution ! |
alexjfisher
deleted the
finish_postgresql_acls_to_resources_hash_conversion
branch
…_acls_to_resources_hash_conversion Finish conversion of `postgresql_acls_to_resources_hash` function
In #1129 the 3 functions from this module were ported to the modern function API and namespaced. None of the boilerplate was fixed up, tests weren't updated, documentation wasn't updated etc.
This commit finishes the work for the
postgresql_acls_to_resources_hashfunction.The existing function documentation made it pretty clear that this function is for internal use only. As such, I've marked it
@api privateand haven't created a non-namespaced shim (like I've being doing with the other functions in this module).