Finish conversion of postgresql_escape function
#1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
force-pushed
the
finish_postgresql_escape_conversion
branch
from
c4f69ab to
51e7fab
Compare
|
Hi @alexjfisher, you have some conflicting files here. Could you rebase ? |
In puppetlabs#1129 the 3 functions from this module were ported to the modern function API and namespaced. None of the boilerplate was fixed up, tests weren't updated, documentation wasn't updated etc. This commit finishes the work for the `postgresql_escape` function. * Remove old API puppet/parser/functions version. * Create a replacement non-namespaced, (but deprecated), new API shim that calls the namespaced version. This function is *probably* not being used outside of this module, but it doesn't hurt to get the old version around for now. * Replace argument validation in the function code with data-type based validation for the individual function parameters. * Refactor function for increased readability. * Test both shim and namespaced version of the function. * Update `postgresql::server` to use namespaced version. * Update REFERENCE.md
alexjfisher
force-pushed
the
finish_postgresql_escape_conversion
branch
from
51e7fab to
788aad6
Compare
|
@daianamezdrea Rebased (which was needed following merging of my other PRs). |
|
@alexjfisher, I think is my fault. Thank you again for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1129 the 3
functions from this module were ported to the modern function API and
namespaced. None of the boilerplate was fixed up, tests weren't
updated, documentation wasn't updated etc.
This commit finishes the work for the
postgresql_escapefunction.that calls the namespaced version. This function is probably not
being used outside of this module, but it doesn't hurt to get the old
version around for now.
validation for the individual function parameters.
postgresql::serverto use namespaced version.