Skip to content

(SUP-2682) Remove Requires= property from timers #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Sep 23, 2021

Prior to this commit, this property created an unwanted dependency
between the timer and service. The effect is that starting the timer
will immediately start the service regardless of the schedule. Removing
this property allows the implicit relationships to work properly.

Prior to this commit, this property created an unwanted dependency
between the timer and service. The effect is that starting the timer
will immediately start the service regardless of the schedule. Removing
this property allows the implicit relationships to work properly.
@m0dular m0dular requested a review from a team as a code owner September 23, 2021 17:23
Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarretlavallee jarretlavallee merged commit e821978 into puppetlabs:main Sep 23, 2021
@m0dular m0dular added the bug label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants