Skip to content

Add initial acceptance tests #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Conversation

carabasdaniel
Copy link
Contributor

@carabasdaniel carabasdaniel commented Jun 24, 2021

Depends on: #74

@carabasdaniel carabasdaniel force-pushed the main branch 4 times, most recently from a132a92 to 1ae819c Compare June 25, 2021 10:19
@MartyEwings
Copy link
Contributor

think we need to add the plugin sync line to spec_helper local after the last PR

@carabasdaniel carabasdaniel force-pushed the main branch 4 times, most recently from 79fbc11 to 40aeef0 Compare June 29, 2021 12:44
@carabasdaniel carabasdaniel marked this pull request as ready for review June 29, 2021 14:22
@carabasdaniel carabasdaniel requested a review from a team as a code owner June 29, 2021 14:22
@jarretlavallee
Copy link
Contributor

This one will need a rebase.

Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge after the jobs finish.

@jarretlavallee jarretlavallee merged commit a638ce5 into puppetlabs:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants