Skip to content

(SUP-3672) Remove legacy code and add spec tests #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2022
Merged

(SUP-3672) Remove legacy code and add spec tests #112

merged 4 commits into from
Nov 7, 2022

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Oct 6, 2022

No description provided.

@m0dular m0dular requested a review from a team as a code owner October 6, 2022 16:33
@m0dular m0dular force-pushed the SUP-3672-spec_tests branch from ea76eb7 to 5d11e72 Compare October 6, 2022 16:35
@m0dular m0dular force-pushed the SUP-3672-spec_tests branch from 894e9df to 1e3a551 Compare October 6, 2022 16:56
MartyEwings
MartyEwings requested changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i think we should also update the readme to reflect the change in the module function?

MartyEwings
MartyEwings requested changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i think we should also update the readme,

And see discussion in the tooling room, we should put all the parameters back in in a standalone fashion, and have a function to alert if they are set:

https://github.com/puppetlabs/puppet-enterprise-modules/blob/main/modules/puppet_enterprise/manifests/deprecated_parameter.pp

@m0dular m0dular force-pushed the SUP-3672-spec_tests branch from b2d2ef8 to fcbc312 Compare October 18, 2022 18:12
@m0dular m0dular force-pushed the SUP-3672-spec_tests branch from fcbc312 to 5a7ed69 Compare October 18, 2022 18:15
@m0dular m0dular mentioned this pull request Nov 4, 2022
Closed
@MartyEwings MartyEwings merged commit c0148df into puppetlabs:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartyEwings MartyEwings MartyEwings approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m0dular @MartyEwings