make systemd timers configurable

[SimonHoenscheid]

closes #107

[puppet-community-rangefinder]

pe_databases::collect is a type

that may have no external impact to Forge modules.

pe_databases is a class

that may have no external impact to Forge modules.

pe_databases::pg_repack is a class

that may have no external impact to Forge modules.

pe_databases::postgresql_settings is a class

that may have no external impact to Forge modules.

pe_databases::postgresql_settings::table_settings is a class

that may have no external impact to Forge modules.

pe_databases::set_puppetdb_table_autovacuum_cost_delay_zero is a type

that may have no external impact to Forge modules.

pe_databases::set_table_attribute is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[MartyEwings]

Due to the nature of this module being shipped with PE, even using a supported module such as stdlib is not something we can do within the confines of this project.

you may just have to declare this as a string

[bastelfreak]

@MartyEwings why can't you vendor stdlib or other modules? Puppet Inc and Vox Pupuli are working on best practice guidelines since years. a few of the topics are:

• make datatypes as strict as possible
• reuse existing datatypes
• rely on puppet/systemd to unify unit management and reduce exec resources to reload systemd

I'm always a bit afraid that new users first check modules from Puppet and assume the used code style is the current best practice. pe_databases would be a bad example here. Would'nt it make more sense to rely on external modules and use them in PE?

[MartyEwings]

@bastelfreak I work within the confines of a contributor to PE from the customer success organization, The overarching product team decides the standards of what is shipped with the Product. Im not sure what the specifics of the stdlib outside of PE discussion was, but there are a few good reasons I'm told.

With regards to dependencies, Everything my group puts in must not interfere with an offline installation, and the more dependencies I have the more my team must maintain and test and package.

In order to get the Product functions we require in, we have built everything for native Puppet Enterprise. Its not ideal, but its the practical way to contribute these functions we consider to be critical

[m0dular]

👍