Skip to content

Add example how to install MySQL 5.6 on CentOS 7 #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2017

Conversation

nvtkaszpir
Copy link
Contributor

This minimal example shows how to install MySQL Community Server 5.6 on Centos 7.3 using Puppet 3.8.7 using hiera and puppet-mysql=3.9.0

Should clarify why #757 does not really make sense, also should help people with fully working example without needing to read about Percona example ;)

….6 on Centos 7.3

This minimal example shows how to install MySQL Community Server 5.6 on Centos 7.3 using Puppet 3.8.7 using hiera.
@tphoney tphoney requested a review from jbondpdx July 3, 2017 13:06
@tphoney
Copy link
Contributor

tphoney commented Jul 3, 2017

@jbondpdx can you give this a once over.

Copy link
Contributor

@jbondpdx jbondpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Thank you.

I've suggested a few minor edits. I understand the wish to be specific about versions, but I think it implies that the example concept only works with these specific versions. (Of course, if that's true, we should certainly call that out!)

README.md Outdated
@@ -322,6 +322,62 @@ Class['apt::update'] ->
Class['::mysql::client']
```

### Install MySQL 5.6 server on CentOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing to ### Install MySQL on CentOS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 'MySQL Community', then?
See below for better explanation.

README.md Outdated
@@ -322,6 +322,62 @@ Class['apt::update'] ->
Class['::mysql::client']
```

### Install MySQL 5.6 server on CentOS

This minimal example shows how to install MySQL Community Server 5.6 on Centos 7.3 using Puppet 3.8.7 using hiera with puppetlabs-mysql=3.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the version numbers are required (that is, the concept doesn't work with other version numbers), I would remove them from the basic description. Suggest changing to:

This example shows how to install MySQL Community Server on CentOS, using Puppet and Hiera.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was to provide real working example of the code, so I've added those versions on purpose, because I did not have time to test it in different setup.
Also yum repo used in hiera explicitly defines MySQL version to use.

I hope this would be a good starting point for anyone else trying to define more generic MySQL section in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I think the version numbers make the sentence harder to parse, so I'd suggest something like:

You can install MySQL Community Server on CentOS using the mysql module and Hiera. This example was tested with the following versions:

  • MySQL Community Server 5.6
  • CentOS 7.3
  • Puppet 3.8.7
  • puppetlabs-mysql 3.9.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.
Done.

README.md Outdated

This minimal example shows how to install MySQL Community Server 5.6 on Centos 7.3 using Puppet 3.8.7 using hiera with puppetlabs-mysql=3.9.0

Puppet:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest

In Puppet:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated
create_resources(mysql::db, hiera('mysql::server::db', {}))
```

Hiera entry:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest:

In Hiera:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated

```yaml
---
# mysql module requies feeding it a bunch of parameters to properly install mysql, and not mariadb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in "requires"

suggest changing "...and not mariadb" to "instead of mariadb" for clarity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with other typos.

Copy link
Contributor

@jbondpdx jbondpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again!

README.md Outdated
@@ -322,6 +322,62 @@ Class['apt::update'] ->
Class['::mysql::client']
```

### Install MySQL 5.6 server on CentOS

This minimal example shows how to install MySQL Community Server 5.6 on Centos 7.3 using Puppet 3.8.7 using hiera with puppetlabs-mysql=3.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I think the version numbers make the sentence harder to parse, so I'd suggest something like:

You can install MySQL Community Server on CentOS using the mysql module and Hiera. This example was tested with the following versions:

  • MySQL Community Server 5.6
  • CentOS 7.3
  • Puppet 3.8.7
  • puppetlabs-mysql 3.9.0

Copy link
Contributor

@jbondpdx jbondpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you so much for the change and for your patience!

@tphoney tphoney merged commit 08005a4 into puppetlabs:master Jul 10, 2017
@tphoney
Copy link
Contributor

tphoney commented Jul 10, 2017

thanks for all the great work @nvtkaszpir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants