Skip to content

MODULES-1520 fix a wrapping of the username when contains - #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

MODULES-1520 fix a wrapping of the username when contains - #633

wants to merge 1 commit into from

Conversation

cyberious
Copy link
Contributor

No description provided.

@@ -127,4 +130,4 @@
end
end

end
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation looks wrong, for the end of the file.

@underscorgan
Copy link
Contributor

I'm not convinced this munging should be happening in the provider instead of the type.

@underscorgan
Copy link
Contributor

(see #623)

@cyberious
Copy link
Contributor Author

I saw that, and the user reported back that it did not resolve the issue. The issue was when using resource mysql_user and how we are not wrapping the username that we get back causes the validation failure.

@underscorgan
Copy link
Contributor

I think the changes maybe belong in the munge method for the user property though (https://github.com/puppetlabs/puppetlabs-mysql/blob/master/lib/puppet/type/mysql_user.rb#L32-L35)

@cyberious
Copy link
Contributor Author

I have tried in the type instead and seems like the munge does not get fired when coming from a resource instances. If I move it to that the unit test breaks completely.

@underscorgan
Copy link
Contributor

#635 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants