-
Notifications
You must be signed in to change notification settings - Fork 795
Install MySQL client and daemon dev libraries. #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What happened to manifests/params.pp and spec/acceptance/mysql_bindings_spec.rb ? |
That would have been fixing Windows putting CRLF at the ends of a line. Let me check if they're correct. Sometimes when I rebase these still show up as changes. |
Yup, windows line endings. I've been putting a test in my rake files for them: https://github.com/Aethylred/puppet-blank/blob/master/Rakefile#L30 |
Generally, the way to fix this would be a .gitattributes file |
I know this is opening another can of worms, but… what about MariaDB? |
MairiaDB is a trick question when there is PostgreSQL, neither are relevant when you're implementing something that only supports MySQL. |
|
ah, does this module install MariaDB? |
Doesn't provide MariaDB for Ubuntu 12.04, which will still be supported until 2017. |
I've made this PR to solve problems with installing Ruby gems that have code that builds against them. Changing from MySQL to MariaDB won't resolve this as the gems will still need these libs to install to operated with a MariaDB. |
Install MySQL client and daemon dev libraries.
This should satisfy https://tickets.puppetlabs.com/browse/MODULES-861
I think I've got the rspec tests correct. Not sure if I've done the acceptance tests right.