Skip to content

Install MySQL client and daemon dev libraries. #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2014

Conversation

Aethylred
Copy link
Contributor

This should satisfy https://tickets.puppetlabs.com/browse/MODULES-861

I think I've got the rspec tests correct. Not sure if I've done the acceptance tests right.

@igalic
Copy link
Contributor

igalic commented May 18, 2014

What happened to manifests/params.pp and spec/acceptance/mysql_bindings_spec.rb ?

@Aethylred
Copy link
Contributor Author

That would have been fixing Windows putting CRLF at the ends of a line. Let me check if they're correct. Sometimes when I rebase these still show up as changes.

@Aethylred
Copy link
Contributor Author

Yup, windows line endings. I've been putting a test in my rake files for them: https://github.com/Aethylred/puppet-blank/blob/master/Rakefile#L30

@igalic
Copy link
Contributor

igalic commented May 19, 2014

Generally, the way to fix this would be a .gitattributes file

@igalic
Copy link
Contributor

igalic commented May 30, 2014

I know this is opening another can of worms, but… what about MariaDB?
[Which, once again reminds me of this piece of sadness]

@Aethylred
Copy link
Contributor Author

MairiaDB is a trick question when there is PostgreSQL, neither are relevant when you're implementing something that only supports MySQL.

@igalic
Copy link
Contributor

igalic commented May 31, 2014

_o uhm… MariaDB is a drop-in replace for MySQL. Some platforms (Fedora) have done exactly that. In a way it's like those weird renames of Apache httpd some distros do.

@Aethylred
Copy link
Contributor Author

ah, does this module install MariaDB?

@igalic
Copy link
Contributor

igalic commented Jun 1, 2014

@Aethylred
Copy link
Contributor Author

Doesn't provide MariaDB for Ubuntu 12.04, which will still be supported until 2017.

@Aethylred
Copy link
Contributor Author

I've made this PR to solve problems with installing Ruby gems that have code that builds against them. Changing from MySQL to MariaDB won't resolve this as the gems will still need these libs to install to operated with a MariaDB.

igalic added a commit that referenced this pull request Jun 3, 2014
Install MySQL client and daemon dev libraries.
@igalic igalic merged commit 6769677 into puppetlabs:master Jun 3, 2014
@Aethylred Aethylred deleted the dev_libs branch June 3, 2014 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants