Fix broken sensitive parameter for mysql::password

[cruelsmith]

Revert broken change of #1557 and fixes the spec test for it by removing the skip.

Fixes #1563

[puppet-community-rangefinder]

mysql::password is a function

Breaking changes to this file WILL impact these 7 modules (exact match):

• qroac-isp3node
• edestecd-mariadb
• cnafsd-storm
• openstack-monasca
• openstack-congress
• openstack-tripleo
• openstack-openstacklib

Breaking changes to this file MAY impact these 1 modules (near match):

• icinga-icinga

mysql_password is a function

Breaking changes to this file WILL impact these 17 modules (exact match):

• mmitchell-puppetlabs_ironic
• dmexe-rails
• nubevps-wordpress
• puppetlabs-wordpress_app
• tscopp-jss
• infnpd-creamce
• maxadamo-galera_maxscale
• mikegleasonjr-wordpress
• hunner-wordpress
• neillturner-wordpress
• ULHPC-slurm
• hfm-mha
• johanek-redmine
• fraenki-galera
• maxadamo-galera_proxysql
• puppet-zabbix
• wdijkerman-zabbix

Breaking changes to this file MAY impact these 26 modules (near match):

• brainfinger-dukesbank
• reidmv-pe_console
• narasimhasv-glance
• dmexe-deploy
• eshamow-pe_cert_auth
• alanpetersen-moodle
• lcgdm-voms
• devopera-domysqldb
• jtopjian-cubbystack
• ploperations-puppet
• vshn-uhosting
• Aethylred-puppetdashboard
• vStone-percona
• gousto-mysql
• midonet-neutron
• stackforge-glance
• stackforge-neutron
• stackforge-heat
• stackforge-nova
• stackforge-cinder
• stackforge-ceilometer
• stackforge-keystone
• openstack-tuskar
• lcgdm-lcgdm
• lcgdm-dmlite
• adam8723-mysql

This module is declared in 140 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[b4ldr]

LGTM

[cruelsmith]

Sry @b4ldr could you check it please once again? I missed the RuboCop ignore rule since i just run the spec test locally.

[jordanbreen28]

LGTM. Thank you @cruelsmith