(maint) Plugins don't exist on 5.1; password field name changed #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunner
force-pushed
the
fix_plugin
branch
3 times, most recently
from
05c9665 to
76536c5
Compare
alexjfisher
reviewed
Oct 15, 2019
| cmd_string << " --databases #{database}" unless database.nil? | ||
| cmd_string << " --user=#{user}" unless user.nil? | ||
| cmd_string << " --password=#{password}" unless password.nil? | ||
| cmd_string << " > #{file}" unless file.nil? | ||
| stdout, stderr, status = Open3.capture3(cmd_string) | ||
| raise Puppet::Error, _("stderr: '#{stderr}'") if status != 0 | ||
| stdout, _stderr, status = Open3.capture3(cmd_string) |
There was a problem hiding this comment.
@hunner This wasn't a hurtful cop. There's a misplaced " on the line below. That's why rubocop was complaining about stderr not being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.