Skip to content

(maint) Plugins don't exist on 5.1; password field name changed #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2018

Conversation

hunner
Copy link
Contributor

@hunner hunner commented Jan 23, 2018

No description provided.

@hunner hunner force-pushed the fix_plugin branch 3 times, most recently from 05c9665 to 76536c5 Compare January 23, 2018 23:56
@eputnam eputnam merged commit 1c1d935 into puppetlabs:master Jan 24, 2018
@hunner hunner deleted the fix_plugin branch January 25, 2018 00:08
cmd_string << " --databases #{database}" unless database.nil?
cmd_string << " --user=#{user}" unless user.nil?
cmd_string << " --password=#{password}" unless password.nil?
cmd_string << " > #{file}" unless file.nil?
stdout, stderr, status = Open3.capture3(cmd_string)
raise Puppet::Error, _("stderr: '#{stderr}'") if status != 0
stdout, _stderr, status = Open3.capture3(cmd_string)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hunner This wasn't a hurtful cop. There's a misplaced " on the line below. That's why rubocop was complaining about stderr not being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants