Allow other manifests to define ::apache::mod{ 'ssl': }. #818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow Apache from the httpd24 SCL on RHELish systems to include the proper mod_ssl package while still letting SSL-enabled
::apache::vhost
defines work as expected.puppetlabs-apache works quite well with the RHEL/CentOS SCLs, like so:
That said, its mod_ssl package is named httpd24-mod_ssl. This can also be worked around on its own:
When an
apache::vhost
is instantiated with the SSL parameter set to true, however, it will include::apache::mod::ssl
, which happens to instantiate::apache::mod { 'ssl': }
without any parameters. This PR allows the details of which package to use for::apache::mod { 'ssl': }
to be defined and still allow SSL-enabled::apache::vhost
defines to work.