Skip to content

(CONT-173) - Updating deprecated facter instances #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Oct 13, 2022

Prior to this commit, this module contained instances of Facter::Util::Resolution.exec and Facter::Util::Resolution.which, which are deprecated. This PR aims to replace these exec helpers with their supported Facter::Core::Execution counterparts.

This PR:

  • Replaced all Facter::Util::Resolution instances with corresponding Facter::Core::Execution exec helpers

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner October 13, 2022 09:56
@jordanbreen28 jordanbreen28 marked this pull request as draft October 13, 2022 10:02
Prior to this commit, this module contained instances of Facter::Util::Resolution.execute and Facter::Util::Resolution.which, which are deprecated.
This commit aims to replace these exec helpers with their supported Facter::Core::Execution counterparts.

This commit:
- Replaced all Facter::Util::Resolution instances with Facter::Core::Execution
@jordanbreen28 jordanbreen28 force-pushed the cont-173/main/updating_deprecated_facter branch from f2c20ae to d970f15 Compare October 13, 2022 10:17
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just note that in #2329 I actually suggest to remove this fact altogether. Not sure if that will be accepted.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review October 13, 2022 10:41
Copy link
Contributor

@chelnak chelnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Please can you update your PR description though? It references commit, and it should be PR.

@chelnak chelnak merged commit a2be9bc into main Oct 13, 2022
@chelnak chelnak deleted the cont-173/main/updating_deprecated_facter branch October 13, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants