Skip to content

fix directory empty options if an empty array is being used #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

bovy89
Copy link
Contributor

@bovy89 bovy89 commented Sep 13, 2022

puppetlabs-apache 6.5.1 with options => false

  <Directory "/var/www/html/myapp">
    AllowOverride None
    Require all granted
  </Directory>

puppetlabs-apache latest with options => []

   <Directory "/var/www/html/myapp">
     Options
     AllowOverride None
     Require all granted
   </Directory>

@bovy89 bovy89 requested a review from a team as a code owner September 13, 2022 14:09
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2022

CLA assistant check
All committers have signed the CLA.

Signed-off-by: bovy89 <bovy89@gmail.com>
@ekohl
Copy link
Collaborator

ekohl commented Sep 13, 2022

Tests are still running

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 6bc1072 into puppetlabs:main Oct 10, 2022
@ekohl ekohl added the bugfix label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants