support lbmethod modules

[xorpaul]

mod_proxy_balancer depends on one of these load balancing scheduler algorithms:

• mod_lbmethod_byrequests
• mod_lbmethod_bytraffic
• mod_lbmethod_bybusyness
• mod_lbmethod_heartbeat

See https://httpd.apache.org/docs/2.4/mod/mod_proxy_balancer.html

This adds support to include one of them via:

class { 'apache::mod::lbmethod_byrequests': }

Maybe apache::mod::lbmethod_byrequests should even fail if none of these 4 are included?

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

apache::mod::lbmethod_bybusyness is a class

that may have no external impact to Forge modules.

apache::mod::lbmethod_byrequests is a class

that may have no external impact to Forge modules.

apache::mod::lbmethod_bytraffic is a class

that may have no external impact to Forge modules.

apache::mod::lbmethod_heartbeat is a class

that may have no external impact to Forge modules.

This module is declared in 174 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[ekohl]

It would be good to have some basic unit tests for these classes.

[ekohl]

Minimal specs in https://github.com/puppetlabs/puppetlabs-apache/tree/main/spec/classes/mod would be nice to have. That way at least the catalog is compiled and verified.

[xorpaul]

@ekohl Ok, thanks. I'll check it out.

[xorpaul]

Is there any way to trigger only my new tests and not the whole test suite which takes over 6 minutes on my workstation?

[david22swan]

@xorpaul You can target specific test files as shown below:

bundle exec rspec spec/unit/puppet/provider/iptables_spec.rb

[david22swan]

@xorpaul Hey, just checking in on how this is progressing

[xorpaul]

After upgrading my workstation to Ubuntu 22.04 the bundle commands do not work anymore.

I'm getting

$ bundle install
Could not find gem 'puppet-module-posix-default-r3.0 (~> 1.0)' in any of the gem sources listed in your Gemfile.
$ bundle exec rake parallel_spec
/usr/bin/env: ‘ruby2.5’: No such file or directory

Is there a way to make this work with more recent OS versions?

[david22swan]

@xorpaul You could try deleting the gem folder and gemfile.lock file

[ekohl]

@xorpaul I recognize the pain you have. Sadly PDK is in a horrible place regarding modern Ruby support. https://tickets.puppetlabs.com/browse/MODULES-11161 has been open for a long time. I always end up hacking Gemfile and hardcode minor_version = '2.7' here:

puppetlabs-apache/Gemfile

Line 17 in 648332c

minor_version = ruby_version_segments[0..1].join('.')

Or I just rely on CI to do testing.

[david22swan]

@xorpaul The issue you were having should now be resolved.

[david22swan]

LGTM
@xorpaul Sorry for the wait, this just sort of slipped out of mind.
Thank's for getting the work done.