Correct vhost parameter documentation and run vhost tests on all supported OSes #2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to see if a mod is present.
The previous location was testing it on a vhost that's absent. This is now testing it on the very complex test where it's present. This is important because in the future the whole directories concat fragment isn't rendered on absent vhosts.
This splits off the fastcgi tests to its own case with proper conditionals. This allows testing the entire define on all supported operating system versions. FastCGI is actually unavailable on all supported Debian versions, rather than just Ubuntu so those are skipped as well.
david22swan
reviewed
Jun 30, 2022
| end | ||
|
|
||
| # this setup uses fastcgi wich isn't available on RHEL 7 / RHEL 8 / Debian / Ubuntu | ||
| unless facts[:os]['family'] || (facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'].to_i >= 7) |
There was a problem hiding this comment.
Annoyed that I missed this before I merged, but this doesn't look right.
There was a problem hiding this comment.
Think there is a compare missing from the first part.
There was a problem hiding this comment.
Oh yes, my bad. That should have been facts[:os]['family'] == 'Debian'. I'm out today and tomorrow so if you haven't fixed it up before Monday I'll submit a patch then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See invididual commits for details. This doesn't modify any code, it's just tests and docs.