mod_auth_gssapi: Add support for GssapiBasicAuth.

[olifre]

This adds support for the GssapiBasicAuth setting
which allows to fall back to basic auth if NEGOTIATE fails.

[puppet-community-rangefinder]

apache::vhost is a type

Breaking changes to this file WILL impact these 129 modules (exact match):

• theforeman-foreman
• theforeman-pulpcore
• ploperations-github
• Aethylred-apaxy
• covermymeds-sentry
• puppetlabs-dashboard
• natewalck-munki_appliance
• landcareresearch-pidservice
• thoherr-railsapp
• danieldreier-puppet_installer
• ganeshselva95-myapp
• sasireddyfm-myapp
• puppetlabs-awsdemo_profiles
• lightoze-bacula
• southernhill-phpldapadmin
• premkumarp-myapp
• syellapu-myapp
• glarizza-osx_management
• saw-reviewboard
• gajdaw-django_app
• katello-foreman_proxy_content
• kumarmks6-myapp
• thomasvandoren-pypi
• puppetlabs-wordpress_app
• abstractit-icinga
• boyand-graphite
• gardouille-xymon
• martialblog-limesurvey
• garystafford-apache_example_config
• thejandroman-grafana
• devika-myapp
• stephenrjohnson-puppet
• zivtech-drupal_php
• SchnWalter-happydev
• glarizza-profiles
• brucem-ezpublish
• wyrie-nagiosql
• garethr-wackopicko
• katello-crane
• pkumarnath-myapp
• 42ways-railsapp
• gerardkok-reposado
• rjbalest-praxis
• puppet-smokeping
• fsalum-dashboard
• hgkamath-owncloud
• aimonb-nexusis_gerrit
• kritz-vagrantlamp
• binford2k-drupal
• xdrum-puppet
• snaragoni-myapp
• crayfishx-puppetdb_rundeck
• cnacorrea-puppet
• garethr-graphite
• rendhalver-icinga
• abstractit-puppet
• pwaghray-myapp
• johanek-redmine
• spotify-talos
• leonardothibes-phpmyadmin
• dmcnicks-sympa
• ranjithsimple-myapp
• zordrak-puppet
• Firebladee-moodle
• pinguinag-reprepro
• cirrax-autoconfigmail
• gene1wood-ipquery
• Aethylred-puppetdashboard
• ghoneycutt-yum
• openstack-ironic
• cristifalcas-kibana
• objectiflibre-puppet
• openstackci-dashboard
• tejoyasha-myapp
• arden-local_rpm_repo
• jgazeley-speedtest
• vinish098-myapp
• ploperations-puppet
• openstack-openstacklib
• norisnetwork-ceph
• gajdaw-phpmyadmin
• openstack-ceph
• benjaminrobertson-observium
• puppetlabs-mrepo
• martasd-mediawiki
• aimonb-nexusis_mediawiki
• monkygames-beansbooks
• marcdeop-ratticdb
• pltraining-classroom_legacy
• katello-capsule
• camlow325-grafanadash
• thexa4-secrets_server
• sgnl05-racktables
• cirrax-postfixadmin
• datacentred-nfsen
• fheinle-webserver
• jlondon-phpmyadmin
• puppet-zabbix
• mricon-bugzilla
• cirrax-roundcube
• tomkrieger-pxe_install
• thejandroman-kibana3
• wdijkerman-zabbix
• eshamow-simpleid
• hexmode-mediawiki
• urgi-galaxy_roles_profiles
• stackforge-keystone
• leonardothibes-usvn
• mtsinc1-trac
• gajdaw-symfony
• eschiller-trac
• jgazeley-nagios
• monkygames-landscape
• seteam-role
• bp85-mirror_repos
• landcareresearch-ckan
• puppet-mrepo
• fancyolaya-dokuwiki
• zyronix-dokuwiki
• abiquo-abiquo
• nnutter-testdb
• shoekstra-owncloud
• hetzner-roundcube
• geoffwilliams-r_profile
• katello-pulp
• Aethylred-gitlab
• stesie-gluon
• icann-webapp
• nwolfe-loadtest

Breaking changes to this file MAY impact these 34 modules (near match):

• opuscodium-taiga
• example42-puppet
• hunner-gitolite
• soli-wrappers
• example42-graylog2
• evenup-graphite
• puppet-php
• spotify-puppetexplorer
• Azcender-balancer
• camptocamp-catalog_diff
• jbussdieker-graphite_web
• example42-wordpress
• nwaller-mailman
• covermymeds-ruby
• example42-kibana
• alexggolovin-opencart
• grahamgilbert-crypt
• openstack-tripleo
• echoes-wrappers
• jcalles-php
• mayflower-php
• tedivm-hieratic
• nibalizer-puppetboard
• puppet-puppetboard
• Lavaburn-cabot
• example42-foreman
• example42-tomcat
• puppetfinland-librenms
• samuelson-dockeragent
• gajdaw-php5
• pltraining-dockeragent
• rspiak-racktables
• pieterdp-hx_website
• zyronix-ipsets

This module is declared in 172 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[olifre]

I believe the change fits into:
https://puppet.com/community/trivial-patch-exemption-policy/
(link currently broken, but I hope I remember the content correctly). So no CLA signing should be needed (I am anyways lacking the necessary understanding of the legalese to sign it without support).

[ekohl]

From a technical perspective this looks correct. The test failures look unrelated.

I can't comment on the legal side but I've pinged someone who might.

[ekohl]

I am wondering about this and whitespace. It looks correct, but have you manually verified this looks sane?

[olifre]

Yep, it does:

  <Location "/somewhere">
    <RequireAll>
      Require user abc
    </RequireAll>
    AuthType GSSAPI
    AuthName "My ID"
      
    # mod_auth_gssapi configuration
    GssapiBasicAuth On
    GssapiSSLonly Off
    GssapiLocalName On
    GssapiCredStore keytab:/etc/httpd/conf/http.keytab
  </Location>

[binford2k]

Hey @olifre! We have actually removed the TPE because it required engineers and contributors to make legal decisions without necessarily having the expertise to do so.

That said, the new CLA is basically the well-known Apache CLA with s/Apache Software Foundation/Puppet/, so it might be easier than you expect to get that approved.

Note; yeah, I know the web page still references the old CLA, I've poked the web team to update it!

[olifre]

Hi @binford2k ,

I did raise the CLA issue in various circles here, and people are at least aware of it. In administration, this may take a year or longer, though (if we are lucky).
However, it seems that this PR has been superseded by #2214 (which adds all these options and many more) or #2215 (which adds some options, but notably, the one added here). So I guess this one can be closed in favour of the others?

[github-actions]

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

[olifre]

I have no feedback concerning CLA signing from my organization yet. Adding this (not helpful for the PR) comment to keep stalebot at bay.

[david22swan]

@olifre Sorry for the wait on review, anyway this change look's good to me and the failures are unrelated so I feel comfortable to go ahead and merge.

Thank's for putting in the work.