Skip to content

(MAINT) Add matrix for acceptance tests #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2022
Merged

(MAINT) Add matrix for acceptance tests #324

merged 2 commits into from
Oct 13, 2022

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented Oct 10, 2022

This PR preps puppet-strings to use the new reusable GitHub actions. We've surface the matrix in calling workflows now and also changed the way the acceptance tests work. When calling the reusable acceptance workflow, it expects that the caller implements a rake task called acceptance with the required steps inside.

@chelnak chelnak requested a review from a team as a code owner October 10, 2022 20:38
@chelnak chelnak self-assigned this Oct 10, 2022
@chelnak chelnak force-pushed the maint-matrix branch 2 times, most recently from 5cd1de1 to bfcda19 Compare October 10, 2022 20:56
@chelnak chelnak force-pushed the maint-matrix branch 13 times, most recently from 14156d4 to 730bb4f Compare October 12, 2022 16:20
@chelnak chelnak closed this Oct 13, 2022
@chelnak chelnak reopened this Oct 13, 2022
This commit prepares the CI workflow so that it can consume the new ci
and acceptance workflows for gems. It also implements a matrix that is
passed in to the rake task as the MATRIX_TARGET environment variable.
This commit completes the acceptance test implementation by adding a new
Rake task. This task is a parent task that calls subtasks that use
litmus for testing.
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@GSPatton GSPatton merged commit 1d1f170 into main Oct 13, 2022
@GSPatton GSPatton deleted the maint-matrix branch October 13, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants