Skip to content

v8: add missing <cstdint> includes. #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions bazel/external/v8_include.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# fix include types for late clang (15.0.7) / gcc (13.2.1)
# for Arch linux / Fedora, like in
# In file included from external/v8/src/torque/torque.cc:5:
# In file included from external/v8/src/torque/source-positions.h:10:
# In file included from external/v8/src/torque/contextual.h:10:
# In file included from external/v8/src/base/macros.h:12:
# external/v8/src/base/logging.h:154:26: error: use of undeclared identifier 'uint16_t'

diff --git a/src/base/logging.h b/src/base/logging.h
--- a/src/base/logging.h
+++ b/src/base/logging.h
@@ -5,6 +5,7 @@
#ifndef V8_BASE_LOGGING_H_
#define V8_BASE_LOGGING_H_

+#include <cstdint>
#include <cstring>
#include <sstream>
#include <string>
diff --git a/src/base/macros.h b/src/base/macros.h
--- a/src/base/macros.h
+++ b/src/base/macros.h
@@ -5,6 +5,7 @@
#ifndef V8_BASE_MACROS_H_
#define V8_BASE_MACROS_H_

+#include <cstdint>
#include <limits>
#include <type_traits>

diff --git a/src/inspector/v8-string-conversions.h b/src/inspector/v8-string-conversions.h
--- a/src/inspector/v8-string-conversions.h
+++ b/src/inspector/v8-string-conversions.h
@@ -5,6 +5,7 @@
#ifndef V8_INSPECTOR_V8_STRING_CONVERSIONS_H_
#define V8_INSPECTOR_V8_STRING_CONVERSIONS_H_

+#include <cstdint>
#include <string>

// Conversion routines between UT8 and UTF16, used by string-16.{h,cc}. You may
5 changes: 4 additions & 1 deletion bazel/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ def proxy_wasm_cpp_host_repositories():
commit = "6c8b357a84847a479cd329478522feefc1c3195a",
remote = "https://chromium.googlesource.com/v8/v8",
shallow_since = "1664374400 +0000",
patches = ["@proxy_wasm_cpp_host//bazel/external:v8.patch"],
patches = [
"@proxy_wasm_cpp_host//bazel/external:v8.patch",
"@proxy_wasm_cpp_host//bazel/external:v8_include.patch",
],
patch_args = ["-p1"],
)

Expand Down