get dev images optimized from cloudinary #2
Merged
+98
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dionvogliqi
approved these changes
Aug 26, 2024
borna9II
reviewed
Aug 28, 2024
| @@ -3,6 +3,7 @@ | |||
| .DS_Store | |||
| .AppleDouble | |||
| .LSOverride | |||
| .idea | |||
Comment on lines
+5
to
+25
| src: string, | ||
| alt: string, | ||
| width: number, | ||
| height: number, | ||
| quality?: { | ||
| type: string, | ||
| default: 'q_auto:best', | ||
| }, | ||
| crop?: { | ||
| type: string, | ||
| default: 'c_fit', | ||
| }, | ||
| faceRecognition?: { | ||
| type: boolean, | ||
| default: false, | ||
| }, | ||
| loading?: 'lazy' | 'eager', | ||
| className?: { | ||
| type: string, | ||
| default: '', | ||
| }, |
| }, | ||
| }>() | ||
|
|
||
| const cloudinaryUrl = 'https://res.cloudinary.com/proxify-io/image/upload' |
TamaraZoric
reviewed
Sep 9, 2024
| <script setup lang="ts"> | ||
| import { computed } from 'vue' | ||
|
|
||
| const props = defineProps<{ |
There was a problem hiding this comment.
@borna9II @29avet1 This is almost correct vue 3 syntax. If you want to add default values for the props we should use
const props = withDefaults(defineProps<{
src: string
alt: string
width: number
height: number
quality?: string
crop?: string
faceRecognition?: boolean
loading?: 'lazy' | 'eager'
class?: string
....
}>(), {
quality: 'q_auto:best',
crop: 'c_fit',
faceRecognition: false,
class: '',
....
});
I do not know it if we want to update this and also if PR to Vue is published.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
jpg images load longer
Proposed Solution
get size-optimized images from cloudinary storage in webp format
Additional Information