-
Notifications
You must be signed in to change notification settings - Fork 738
RadioList: search #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RadioList: search #758
Conversation
Hi @gpotter2, |
Hi, I understand that the search system I a bit « raw » and would require some tweaks |
Hi @gpotter2, Notice that actually for a text area, page up/down also changes the scroll offset of the window. Pressing page-down keeps the cursor at the top of the window, and page-up keeps it at the bottom of the window. For now, I propose however to keep it like it is. |
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
==========================================
- Coverage 70.99% 70.86% -0.14%
==========================================
Files 144 144
Lines 13616 13642 +26
==========================================
Hits 9667 9667
- Misses 3949 3975 +26
Continue to review full report at Codecov.
|
@jonathanslenders Here it is #761 Please tell me if you have in mind an implementation of a searching system that would fit better. |
Hey ! Sorry for the ping, any news on such a thing ? I understand you have little time for this, feel free to tell me any improvements/changes that should be done, or that you don't want to implement it that way for X reasons 😄 |
Closed for inactivity, and because it's going to conflict with too many things soon. This could probably be integrated in a much more elegant way (using some internal functions / bindings to the existing search API ?) |
This PR genually improves RadioList by:
pageup
andpagedown
keysI'm of course open to any suggestions.
Note: I tried several implementations of the searching system. The first one aimed at adding
> [the text]
above or below the frame. However, due to how the scrolling is implemented, it was harder than expected, which is why I rolled-back to a simpler color-based searching system. I can elaborate if needed