-
Notifications
You must be signed in to change notification settings - Fork 738
ThreadedHistory: invoke Buffer.new_history_item() on event loop from background thread #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…prompt-toolkit into th-threadsafe-load
Oh noes! many errors from OTOH, this check did find some nits in code I did touch, and I will push fixes for those... |
Resolved remaining |
Thanks for this. The Mypy errors are probably because of a new recent mypy release. I look into that. Thanks again for the fix! I review it ASAP. |
Hi @bobhy, The mypy issues were solved in this PR: #1167 (comment) (slightly differently - I don't like to ignore errors.) Can you rebase this branch on master, and squash the remaining changes? |
My git fu is weak. I have merged from master and will work on the rebase next. |
.. have rebased on master, but still cannot get rebase to squash my subsequent interim commits, need advise or help! |
I have successfully squashed all the commits, but now cannot merge that tree into this branch (error is "error: failed to push some refs, hint: Updates were rejected because the tip of squashed branch is behind its remote counterpart") Will push nice, clean PR to new branch and close this one. |
Fixes issue #1158, and seems to work in Xonsh as well.
Depends on ThreadedHistory and Application being able to rendezvous on same event loop. While this may not be possible for history in general, I think it is an acceptable restriction on ThreadedHistory.