mouse support not working in windows

[EricBalingit]

Hi,

I'm not having any luck getting mouse to work with mouse_support=True. Tried manual enable application.output.enable_mouse_support() but no errors are thrown. Still finding my way around the lib, but looking to log event types and see what comes through.

So far on:
Windows 10 pro Version 10.0.19041, 64 bit
Windows 10 home Version 10.0.18363, 64 bit

I do not have access to a system where it does work for me, so far, only the above. And I haven't tried using kernel32 directly.

Interestingly mouse works fine through win32console, but both seem to be using windows api, so not sure what gives. I've been comparing libs and looked at https://github.com/peterbrittain/asciimatics, but I really like your layout engine and want to use pt.

Also worth noting, results are same for pt vs asciimatics ( which uses win32console, though I don't know if this makes any difference implementation-wise vs kernel32 ) in cmd.exe as well as powershell - pt no mouse, asciim works, but in the new Windows Terminal, neither work, but that's not surprising really, it's still pretty new.

I'll keep you posted, and please ask if there's anything I can do to help you get this sorted. :-)

[EricBalingit]

It looks like mouse support is enabled on the output handle. Should be enabled on the input handle mode. I'll have a look at it when I get a chance.

[EricBalingit]

Apparently quick edit mode was interfering with mouse event processing.

ENABLE_QUICK_EDIT_MODE = 0x0040
...
self._winapi(
            windll.kernel32.SetConsoleMode,
            handle,
            ( original_mode.value | ENABLE_MOUSE_INPUT ) & ~ENABLE_QUICK_EDIT_MODE
        )

solved the problem.

I left some comments in the code.

Can send a pull request if you like.

But it's probably worth reading the api a little more carefully in any case. For example still not sure why cursor hide and show does not work, even though these are documented. Possibly because stdin is not explicitly GENERIC_READ, or rather I don't know what os.O_RDWR means.

[EricBalingit]

It also says

To enable this mode, use ENABLE_QUICK_EDIT_MODE | ENABLE_EXTENDED_FLAGS. To disable this mode, use ENABLE_EXTENDED_FLAGS without this flag.

Which implies that ENABLE_EXTENDED_FLAGS is set by default, so I should make that explicit, but strangely, there is no mention of this with regard to ENABLE_MOUSE_INPUT. I just saw this in another code base and tried it. I suppose it makes sense but nothing about it is documented, so may be a bug.

[625781186]

@jonathanslenders

#1059

Maybe you can take a look.

[EricBalingit]

I think this will fix it for him too. Something tells me, windows is a beast. :D

I'll link him here and see if he sees it.