Add 0.5 comments support #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasm
suggested changes
Jan 22, 2018
There was a problem hiding this comment.
Hey @zbraniecki, sorry it took me a while to get to reviewing this. Is this complete? It looks like it might be missing the changes to the AST as well as the logic for differentiating between different comment levels and changes in the serializer. Also, Section is still around.
|
I doubt its up to date. It was only completed as of Dec 13th. |
|
Do you plan to work on it? |
zbraniecki
force-pushed
the
05-comments
branch
3 times, most recently
from
0728990 to
7ea7af6
Compare
zbraniecki
force-pushed
the
05-comments
branch
from
7ea7af6 to
2eeb7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a subset of projectfluent/fluent#58 required for limited Firefox x-channel compatibility across beta and stable.