(@fluent/react) Add changeLocales and currentLocales on provider #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macabeus
commented
Jul 8, 2020
Comment on lines
+6
to
+7
| changeLocales: (_changeLocales: string[]) => undefined as void, | ||
| currentLocales: [] as string[], |
There was a problem hiding this comment.
Since we have a setter and a reader, maybe we could call they as locales and setLocales?
macabeus
commented
Jul 8, 2020
Comment on lines
+35
to
+36
| props.changeLocales(locales); | ||
| setLocales(locales); |
There was a problem hiding this comment.
There aren't any check if the prop.changeLocales was succeeded before to call setLocales. Maybe we could return a bool on changeLocales? Or use await props.changeLocales(locales) in order to fail on except?
macabeus
commented
Jul 8, 2020
| @@ -5,9 +5,9 @@ import { ReactLocalization } from "./localization"; | |||
| /* | |||
| * The `useLocalization` hook returns the FluentContext | |||
| */ | |||
| type useLocalization = () => { l10n: ReactLocalization } | |||
| type useLocalization = () => { l10n: ReactLocalization, changeLocales: (locales: string[]) => void, currentLocales: string[] } | |||
There was a problem hiding this comment.
I'm writing the type (locales: string[]) => void 2~3 times. Maybe we could to name this type and export/import from somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes this issue: #500
This PR aims to add on
useLocalizationa function to change the current locale,changeLocales. So on a nested component will can to updates the locale. It's useful for a "choice language" selector.In addition to returning
changeLocalesonuseLocalization, I also added to returncurrentLocales, in order to avoid two sources of truth. So a "choice language" selector will need just to read the current language from the provider.I also updated the example adding the component "choice language".