Create a Github action for MCAD CI check

[Srihari1192]

Fixes #480

[Srihari1192]

I have been testing this in my fork branch and will update the PR once testing is done

[z103cb]

These changes look good to me so far, but I think you should consider the following enhancements:

1. Pre-install the following things:

• kind (latest version available)
• kubectl
• kuttl (kubectl plugin)

2. Configure the docker daemon to only have

• 2 CPU
• 8 GB of RAM.

The last bit is important for getting the end to end to run correctly, as they assume a certain amount of CPU's available to MCAD's kind cluster.

[sutaakar]

AFAIK the current GitHub runner has 2 CPU and 7GB of memory. Not sure if the memory difference may cause some issues.

[Srihari1192]

Tested this workflow in my fork repository , tests are looks good https://github.com/Srihari1192/multi-cluster-app-dispatcher/actions/workflows/mcad-CI.yml

[Srihari1192]

These changes look good to me so far, but I think you should consider the following enhancements:

1. Pre-install the following things:

• kind (latest version available)
• kubectl
• kuttl (kubectl plugin)

2. Configure the docker daemon to only have

• 2 CPU
• 8 GB of RAM.

The last bit is important for getting the end to end to run correctly, as they assume a certain amount of CPU's available to MCAD's kind cluster.

@z103cb Thanks for review
For now we are using existing scripts run-e2e-kind.sh to install and run the test. I think we can refactor Pre-install things when we remove completely travis CI , as the changes will impact to Travis CI main branch merge build trigger

[z103cb]

These changes look good to me so far, but I think you should consider the following enhancements:

1. Pre-install the following things:

• kind (latest version available)
• kubectl
• kuttl (kubectl plugin)

2. Configure the docker daemon to only have

• 2 CPU
• 8 GB of RAM.

The last bit is important for getting the end to end to run correctly, as they assume a certain amount of CPU's available to MCAD's kind cluster.

@z103cb Thanks for review For now we are using existing scripts run-e2e-kind.sh to install and run the test. I think we can refactor Pre-install things when we remove completely travis CI , as the changes will impact to Travis CI main branch merge build trigger

@Srihari1192 Hopefully this line is not causing a problem for your test.

[z103cb]

AFAIK the current GitHub runner has 2 CPU and 7GB of memory. Not sure if the memory difference may cause some issues.

I don't think they would most of the e2e tests depend mostly on available CPU. @Srihari1192 would be possible to view the output of your run ?

[Srihari1192]

These changes look good to me so far, but I think you should consider the following enhancements:

1. Pre-install the following things:

• kind (latest version available)
• kubectl
• kuttl (kubectl plugin)

2. Configure the docker daemon to only have

• 2 CPU
• 8 GB of RAM.

The last bit is important for getting the end to end to run correctly, as they assume a certain amount of CPU's available to MCAD's kind cluster.

@z103cb Thanks for review For now we are using existing scripts run-e2e-kind.sh to install and run the test. I think we can refactor Pre-install things when we remove completely travis CI , as the changes will impact to Travis CI main branch merge build trigger

@Srihari1192 Hopefully this line is not causing a problem for your test.

Yes the mentioned line is not causing a problem in test and also Unit test and E2E tests results looks good https://github.com/Srihari1192/multi-cluster-app-dispatcher/actions/runs/5619138250/job/15225780359

[z103cb]

We'll need a follow on PR/issue to remove travis support (i.e .travis.yaml) all together, but this is looking good.

[z103cb]

@Srihari1192 we need to make sure that these variables are set when calling make images.

"---"
"MAKE GLOBAL VARIABLES:"
"  "BIN_DIR="_output/bin"
"  "GIT_BRANCH=""
"  "RELEASE_VER=""
"  "TAG=""
"  "GO_BUILD_ARGS=""
"---"
# Check for 

[Srihari1192]

@Srihari1192 we need to make sure that these variables are set when calling make images.

"---"
"MAKE GLOBAL VARIABLES:"
"  "BIN_DIR="_output/bin"
"  "GIT_BRANCH=""
"  "RELEASE_VER=""
"  "TAG=""
"  "GO_BUILD_ARGS=""
"---"
# Check for 

Yes Build is failing to fetch branch and tag.. looks like some permission required, looking into it

[z103cb]

LGTM.

[sutaakar]

Looks good to me

[z103cb]

This is looking good to me. Letting @asm582 chime in.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar, z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [z103cb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment