Skip to content

Incorrect handling of errors in the worker thread #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 20, 2023
Merged

Incorrect handling of errors in the worker thread #482

merged 4 commits into from
Jul 20, 2023

Conversation

z103cb
Copy link
Contributor

@z103cb z103cb commented Jul 17, 2023

Improved error handling.
Fixes #481

asm582
asm582 reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@asm582 asm582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please fix the typo in the name of test file i think it should be queuejob_controller_ex_test.go

@z103cb z103cb requested a review from asm582 July 18, 2023 11:15
@z103cb z103cb mentioned this pull request Jul 19, 2023
Merged
@metalcycling metalcycling marked this pull request as ready for review July 19, 2023 14:57
@z103cb z103cb self-assigned this Jul 20, 2023
@z103cb
Copy link
Contributor Author

z103cb commented Jul 20, 2023

Thanks for the PR, please fix the typo in the name of test file i think it should be queuejob_controller_ex_test.go

I think this fixed.

metalcycling
metalcycling approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@metalcycling metalcycling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

asm582
asm582 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@asm582 asm582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@z103cb z103cb merged commit edce2c4 into project-codeflare:main Jul 20, 2023
@z103cb z103cb deleted the z103cb/issue481 branch July 20, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalcycling metalcycling metalcycling approved these changes

@asm582 asm582 asm582 approved these changes

@tardieu tardieu Awaiting requested review from tardieu

@astefanutti astefanutti Awaiting requested review from astefanutti

@dimakis dimakis Awaiting requested review from dimakis

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@z103cb z103cb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect handling of errors in the worker thread
3 participants
@z103cb @metalcycling @asm582