Skip to content

remove kubectl installation from Dockerfile #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

KPostOffice
Copy link
Contributor

kubectl doesn't seem to be in use anywhere within the code, so removing it from the Dockerfile should simplify the image creation and shrink the image size somewhat

@KPostOffice KPostOffice requested a review from z103cb June 28, 2023 13:49
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've missed line 22

COPY --from=BUILDER /workdir/kubectl /usr/local/bin

@z103cb z103cb self-requested a review June 28, 2023 13:56
@KPostOffice
Copy link
Contributor Author

function kuttl-tests {

I found this in the testing directory. Is the Dockerfile installing kubectl for testing? If it is then I'm wondering whether another Dockerfile needs to be created as CI specific tooling and code shouldn't be part of the final controller image.

kubectl doesn't seem to be in use anywhere within the code, so removing
it from the Dockerfile should simplify the image creation and shrink
the image size somewhat

Signed-off-by: Kevin <kpostlet@redhat.com>
@z103cb
Copy link
Contributor

z103cb commented Jul 17, 2023

@KPostOffice feel free to merge this if you have no rights, I will merge it in the morning.

@z103cb z103cb merged commit aebfcfc into project-codeflare:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants