Added e2e test to reproduce issue #340 #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
z103cb
commented
May 29, 2023
z103cb
commented
- Added e2e test to replicate issue [quota-management] Release quota entitlements after Running AWs are resubmitted #340
- Minor fixes in the e2e script.
Minor fixes in the e2e script.
|
@KPostOffice can you review the setup in the e2e test let me know if it matches what you observed when you filed #340? @KPostOffice, @metalcycling and @asm582 I can't seem to reproduce issue #340 after merging #367. I would appreciate some help in determining if the issue is still present. I think that the e2e test additions do have value even if we can't reproduce the original issue. |
z103cb
commented
May 30, 2023
pkg/controller/quota/quotaforestmanager/qm_lib_backend_with_quotasubt_mgr.go
Show resolved
Hide resolved
metalcycling
approved these changes
Jun 1, 2023
This was referenced May 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.