Quota release when AppWrapper is completed

[metalcycling]

No description provided.

[asm582]

Thanks, I think we should release the quota when AW does not have Running or RunningHoldCompletion

[metalcycling]

I've been thinking about this, and I believe the only time the quota should be released is when the AppWrapper is Completed, Preempted, or Failed. Other times can cause problems. For example if the AppWrapper is Dispatched and there is no quota in the tree reserved for that state (because it wasn't Running or RunningHoldCompletion), then the next AppWrapper would be dispatched since the system thinks the quota is free. We should only release quota when we are certain the AppWrapper is done, either by completing, by failing, or by being preempted.

[asm582]

I've been thinking about this, and I believe the only time the quota should be released is when the AppWrapper is Completed, Preempted, or Failed. Other times can cause problems. For example if the AppWrapper is Dispatched and there is no quota in the tree reserved for that state (because it wasn't Running or RunningHoldCompletion), then the next AppWrapper would be dispatched since the system thinks the quota is free. We should only release quota when we are certain the AppWrapper is done, either by completing, by failing, or by being preempted.

Are we not talking about the same thing?

[metalcycling]

After testing this change for all the AppWrapper conditions (meaning testing quota after triggering any of these conditions):

• Pending
• Running
• Deleted
• Failed
• Completed
• RunningHoldCompletion

I can see quota is being release correctly for all these cases once this code change is added. This ready for review.

[asm582]

After testing this change for all the AppWrapper conditions (meaning testing quota after triggering any of these conditions):

• Pending
• Running
• Deleted
• Failed
• Completed
• RunningHoldCompletion

I can see quota is being release correctly for all these cases once this code change is added. This ready for review.

Thanks, why should the quota be released for RunningHoldCompletion status?

[metalcycling]

I didn't mean it was released for that status. Just that I tested all those cases. I can see how that is confusing. I'll update the text to clarify which is which.

[z103cb]

This is looking good!

[asm582]

We discussed in the call, as per my understanding the quota is not released when AW is in status Running and RunningHoldCompletion