Increase the timeout limit. #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, waiting for the build to succeed :) |
|
Only two tests are failing which are due to VM resource jitter I think, approving |
asm582
previously approved these changes
May 5, 2023
|
Build is still failing. Should I approve it anyway? |
|
|
is the build failing due to quota tests? |
No, it is this test: "MCAD Scheduling Fail Fast Preemption Test". I am running locally, only with this test and a timeout of 100 minutes for this test. |
|
Thanks, we should re-write that test, if that is the only test which is failing, I vote for merging this PR |
metalcycling
previously approved these changes
May 8, 2023
|
I'm good if @asm582 is good. I accepted the changes. |
- Increased timeout for kuttl steps - increased CPU requests for the fast preemption tests - reduced the number of app wrappers submitted, simplified code
asm582
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the builds are falling due to resource state not being what is expected. While the builds run locally, on travis they seem to be failing. This PR attempts to address some of the failures.