Skip to content

[quota management] MCAD panic in quota release when quota management is not enabled #429

Closed
@asm582

Description

@asm582
E0625 19:12:52.286084 1 queuejob_controller_ex.go:1851] [worker] Panic occurred error: runtime error: invalid memory address or nil pointer dereference, stacktrace: goroutine 563 [running]:
runtime/debug.Stack()
/usr/lib/golang/src/runtime/debug/stack.go:24 +0x65
github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/controller/queuejob.(*XController).worker.func1()
/workdir/pkg/controller/queuejob/queuejob_controller_ex.go:1851 +0x4b
panic({0x19186a0, 0x2b7f5e0})
/usr/lib/golang/src/runtime/panic.go:838 +0x207
github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/controller/queuejob.(*XController).manageQueueJob(0xc0006f9200, 0xc001f66000, 0x1)
/workdir/pkg/controller/queuejob/queuejob_controller_ex.go:2174 +0x4794
github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/controller/queuejob.(*XController).syncQueueJob(0xc0006f9200, 0xc001f66000)
/workdir/pkg/controller/queuejob/queuejob_controller_ex.go:1946 +0x1045
github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/controller/queuejob.(*XController).worker.func2({0x1b259e0?, 0xc001f66000?})
/workdir/pkg/controller/queuejob/queuejob_controller_ex.go:1874 +0x35a
k8s.io/client-go/tools/cache.(*FIFO).Pop(0xc0004cbb90, 0xc000830650)
/opt/app-root/src/go/pkg/mod/k8s.io/client-go@v0.20.0/tools/cache/fifo.go:303 +0x1fc
github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/controller/queuejob.(*XController).worker(0xc0008306a0?)
/workdir/pkg/controller/queuejob/queuejob_controller_ex.go:1854 +0x73
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0x0?)
/opt/app-root/src/go/pkg/mod/k8s.io/apimachinery@v0.20.5/pkg/util/wait/wait.go:155 +0x3e
k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0x0?, {0x1e4eb20, 0xc00164e960}, 0x1, 0xc00047e480)
/opt/app-root/src/go/pkg/mod/k8s.io/apimachinery@v0.20.5/pkg/util/wait/wait.go:156 +0xb6
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0x0?, 0x0, 0x0, 0x0?, 0x0?)
/opt/app-root/src/go/pkg/mod/k8s.io/apimachinery@v0.20.5/pkg/util/wait/wait.go:133 +0x89
k8s.io/apimachinery/pkg/util/wait.Until(0x0?, 0x0?, 0x0?)
/opt/app-root/src/go/pkg/mod/k8s.io/apimachinery@v0.20.5/pkg/util/wait/wait.go:90 +0x25
created by github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/controller/queuejob.(*XController).Run
/workdir/pkg/controller/queuejob/queuejob_controller_ex.go:1617 +0xaea

the fix would be to check if the QM feature is enabled before releasing the quota

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions